Skip to content

Align Copilot formatting guidance with existing linting/formatting skill#7885

Closed
Copilot wants to merge 14 commits into
mainfrom
copilot/sub-pr-7884
Closed

Align Copilot formatting guidance with existing linting/formatting skill#7885
Copilot wants to merge 14 commits into
mainfrom
copilot/sub-pr-7884

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026 •
edited
Loading

This change is a standalone formatting-guide update.

It updates repository guidance for Copilot-driven changes to avoid duplicating formatting instructions already documented in the existing linting/formatting skill.

  • Formatting/CI guidance update

    • Removed duplicated step-by-step CMake remediation guidance from .github/copilot-instructions.md.
    • Kept guidance centralized via the existing Linting and formatting section and linked .github/skills/formatting-and-linting.md.

  • Scope

    • Documentation/instructions only (.github/copilot-instructions.md).
    • No production, test, or source code behavior changes.

Copilot AI and others added 8 commits May 13, 2026 15:58
@maxtropets
Remove stale cchost mentions from tests, samples, schema and host config
ee57b70 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/490c0f29-f328-442f-b280-591c6a302c40

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@maxtropets
Make CCFRemote.BIN empty with comment that it must be set
e32429d 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/16102018-130f-491a-87f7-26ad84e003bf

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@maxtropets
Revert comment change in CCFRemote.__init__
c10ab58 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/944eaa0f-7d80-4808-b871-e5a88fd00c0e

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@achamayou
Stage js_generic on PATH in minimal_ccf runtime Dockerfile
9a81648 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/0a183e74-f64f-4978-9771-7977aa95667e

Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
@maxtropets
Make CCFRemote binary_name an explicit constructor argument
9972214 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/b59a5b76-ce53-4ca6-a87f-bbd792a86407

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@maxtropets
Merge branch 'main' into copilot/remove-cchost-mentions
2e8d8ac
Initial plan
b5da74e
Initial plan
7215a36
Copilot AI mentioned this pull request May 14, 2026
Closed
@maxtropets
Fix CMake formatting using CI formatting script
f1025bb 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/fb2c3354-e196-424f-8e7a-9d52825c3668

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
@maxtropets
Copy link
Copy Markdown
Collaborator

maxtropets commented May 14, 2026

@copilot where are the changes?

@maxtropets maxtropets changed the title [WIP] [WIP] Remove stale cchost mentions across tests, samples, schema, and host config Remove stale cchost mentions across tests, samples, schema, and host config May 14, 2026
Copilot AI changed the title Remove stale cchost mentions across tests, samples, schema, and host config Clarify standalone merge target (main) for stale cchost cleanup PR May 14, 2026
Copilot AI requested a review from maxtropets May 14, 2026 13:05
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot where are the changes?

You’re right — there were no file changes before. I’ve now pushed 32fb0c5, which adds an explicit repo Copilot instruction to always run ./scripts/ci-checks.sh before pushing and to run ./scripts/cmake-format-checks.sh -f when CI reports a CMake format failure (no UI changes to screenshot).

@maxtropets maxtropets marked this pull request as ready for review May 14, 2026 13:22
@maxtropets maxtropets requested a review from a team as a code owner May 14, 2026 13:22
@maxtropets
Copy link
Copy Markdown
Collaborator

maxtropets commented May 14, 2026

@copilot adjust PR description, don't mention ant other PR, it's just a standalone task for the formatting guide.

@maxtropets maxtropets changed the title Clarify standalone merge target (main) for stale cchost cleanup PR Ask copilot to format as per CI requirements in PRs May 14, 2026
@maxtropets maxtropets changed the base branch from copilot/sub-pr-7883 to main May 14, 2026 13:24
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot adjust PR description, don't mention ant other PR, it's just a standalone task for the formatting guide.

Updated the PR description to keep it strictly as a standalone formatting-guide task and removed references to other PRs. No code changes were needed for this update (HEAD: c191052; no UI changes).

Copilot AI changed the title Ask copilot to format as per CI requirements in PRs Update Copilot formatting guidance with CI checks and CMake auto-fix steps May 14, 2026
achamayou
achamayou reviewed May 14, 2026
View reviewed changes
Comment thread .github/copilot-instructions.md Outdated
## Code changes

- `ci-checks.sh` must run successfully before any commit is pushed.
- Always run `./scripts/ci-checks.sh` in the same way as CI before pushing. If it reports `CMake format` failures, run `./scripts/cmake-format-checks.sh -f` and re-run `./scripts/ci-checks.sh` before committing.
Copy link
Copy Markdown
Member

@achamayou achamayou May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a whole skill for this here: https://github.com/microsoft/CCF/blob/main/.github/skills/formatting-and-linting.md, and we have a pointer to it here: https://github.com/microsoft/CCF/blob/main/.github/copilot-instructions.md#linting-and-formatting - surely we should at most point to this section, not repeat the content.

Copy link
Copy Markdown
Collaborator

@maxtropets maxtropets May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot do it

Copy link
Copy Markdown
Contributor Author

Copilot AI May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 8fdeb8e: I removed the duplicated formatting/CMake remediation bullet from .github/copilot-instructions.md, so this now relies on the existing “Linting and formatting” section and linked formatting skill instead of repeating that content. No UI changes to screenshot.

@maxtropets
Copy link
Copy Markdown
Collaborator

maxtropets commented May 15, 2026

@copilot this PR carries unnecesasry changes from the cchost removal, only formatting instructions should stay in this PR.

Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 12:58
Copilot AI changed the title Update Copilot formatting guidance with CI checks and CMake auto-fix steps Align Copilot formatting guidance with existing linting/formatting skill May 15, 2026
Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 13:03
@maxtropets
Fix trailing whitespace in reverted Dockerfile
86826bb 
Agent-Logs-Url: https://github.com/microsoft/CCF/sessions/78b42f5d-4459-4ddc-9130-509c14885e9e

Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot May 15, 2026 13:04
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 15, 2026

@copilot this PR carries unnecesasry changes from the cchost removal, only formatting instructions should stay in this PR.

Done in a275802 (with follow-up cleanup in 86826bb): I removed the unrelated cchost-removal scope from this PR so it no longer carries those extra changes. No UI changes to screenshot.

@maxtropets maxtropets closed this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achamayou achamayou achamayou left review comments

@maxtropets maxtropets Awaiting requested review from maxtropets

Assignees

@maxtropets maxtropets

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxtropets @achamayou